linux-kernel - Re: [PATCH 1/4] ide-pmac: media-bay support fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1214303693.8011.345.camel@pasglop>
Date:	Tue, 24 Jun 2008 20:34:53 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] ide-pmac: media-bay support fixes


> Build error and/or your build fix would be useful here.

Sorry. Fix was a quick hack. There is a check_media_bay() followed by a
break; outside of a break-able construct in there (off memory, I'm not
in front of the dev box right now).

> Ok, I see the problem - we now need to clear dive->noprobe after
> ide_device_add() call (pmac.c) or later ide_port_scan() call (mediabay.c)
> will fail...  also there was a pmif->mediabay check missing...
> 
> Please try the new version of patch #1 (the other patches are unchanged):

Thanks. Will do ASAP tomorrow. I've been kept busy with other more
urgent things today (gotta love having meetings starting at 6AM in the
morning !)

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/