linux-kernel - Re: [PATCH] x86/oprofile: disable preemption in nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080624114917.GE21890@elte.hu>
Date:	Tue, 24 Jun 2008 13:49:17 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Vegard Nossum <vegard.nossum@...il.com>
Cc:	Johannes Weiner <hannes@...urebad.de>,
	Philippe Elie <phil.el@...adoo.fr>, oprofile-list@...ts.sf.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/oprofile: disable preemption in nmi_shutdown


* Vegard Nossum <vegard.nossum@...il.com> wrote:

> From: Vegard Nossum <vegard.nossum@...il.com>
> Date: Sat, 21 Jun 2008 23:44:19 +0200
> Subject: [PATCH] x86/oprofile: disable preemption in nmi_shutdown
> 
>     BUG: using smp_processor_id() in preemptible [00000000] code: oprofiled/27301
>     caller is nmi_shutdown+0x11/0x60
>     Pid: 27301, comm: oprofiled Not tainted 2.6.26-rc7 #25
>      [<c028a90d>] debug_smp_processor_id+0xbd/0xc0
>      [<c045fba1>] nmi_shutdown+0x11/0x60
>      [<c045dd4a>] oprofile_shutdown+0x2a/0x60
> 
> Note that we don't need this for the other functions, since they are 
> all called with on_each_cpu() (which disables preemption for us 
> anyway).

applied to tip/x86/oprofile - thanks Vegard.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/