linux-kernel - Re: [PATCH] fix to putback_lru_page()/unevictable page handling rework v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f11576a0806241035p45a440e1gb798091ef39cffc8@mail.gmail.com>
Date:	Wed, 25 Jun 2008 02:35:51 +0900
From:	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>
To:	"Lee Schermerhorn" <Lee.Schermerhorn@...com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@...fujitsu.com>,
	linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Rik van Riel" <riel@...hat.com>
Subject: Re: [PATCH] fix to putback_lru_page()/unevictable page handling rework v3

> 'lru' was not being set to 'UNEVICTABLE when page was, in fact,
> unevictable [really "nonreclaimable" :-)], so retry would never
> happen, and culled pages never counted.
>
> Also, redundant mem_cgroup_move_lists()--one with incorrect 'lru',
> in the case of unevictable pages--messes up memcontroller tracking [I think].

indeed.
sorry, I forgot to send this fix.

Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>

but I still happend panic on usex and nishimura-san's cpuset migration test.
  -> http://marc.info/?l=linux-mm&m=121375647720110&w=2


I'll  investigate it tommorow.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/