linux-kernel - RE: [PATCH 3/14] arch/ia64: Eliminate NULL test and memset after alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0806241948120.26777@ask.diku.dk>
Date:	Tue, 24 Jun 2008 19:55:44 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	"akinobu.mita@...il.com" <akinobu.mita@...il.com>,
	"linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH 3/14] arch/ia64: Eliminate NULL test and memset after
 alloc_bootmem

On Tue, 24 Jun 2008, Luck, Tony wrote:

> > As noted by Akinobu Mita in patch b1fceac2b9e04d278316b2faddf276015fc06e3b,
> > alloc_bootmem and related functions never return NULL and always return a
> > zeroed region of memory.  Thus a NULL test or memset after calls to these
> > functions is unnecessary.
> 
> There is no commit b1fceac2b9e04d278316b2faddf276015fc06e3b in Linus' tree.

I am not sure to know how to tell precisely where you are looking, but you 
can find it here:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1fceac2b9e04d278316b2faddf276015fc06e3b


> In addition the current alloc_bootmem() is a macro that uses __alloc_bootmem
> which most defintely can return NULL.

The "return NULL;" at the bottom of __alloc_bootmem is preceded by 
panic("Out of memory");, which I assume cannot return?

> Is this against -mm or linux-next?

I pull files from the following git repository:

git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git

julia

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/