linux-kernel - Re: [PATCH] x86: fix pte allocation in "x86: introduce init_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440806241441v5f2c0870g379695cacd5dfb9b@mail.gmail.com>
Date:	Tue, 24 Jun 2008 14:41:18 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Jeremy Fitzhardinge" <jeremy@...p.org>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: fix pte allocation in "x86: introduce init_memory_mapping for 32bit"

On Tue, Jun 24, 2008 at 2:32 PM, Jeremy Fitzhardinge <jeremy@...p.org> wrote:
> The patch "x86: introduce init_memory_mapping for 32bit" does not allocate
> enough space for PTEs if the CPU does not implement PSE.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> Cc: Yinghai Lu <yhlu.kernel@...il.com>
> ---
> arch/x86/mm/init_32.c |    5 +++++
> 1 file changed, 5 insertions(+)
>
> ===================================================================
> --- a/arch/x86/mm/init_32.c
> +++ b/arch/x86/mm/init_32.c
> @@ -733,6 +733,11 @@
>        pmds = (end + PMD_SIZE - 1) >> PMD_SHIFT;
>        tables += PAGE_ALIGN(pmds * sizeof(pmd_t));
>
> +       if (!cpu_has_pse) {
> +               int ptes = (end + PAGE_SIZE - 1) >> PAGE_SHIFT;
> +               tables += PAGE_ALIGN(ptes * sizeof(pte_t));
> +       }
> +
>        /*
>         * RED-PEN putting page tables only on node 0 could
>         * cause a hotspot and fill up ZONE_DMA. The page tables
>
thanks.

my test system never use the area from table_start to table_end. and I
wonder why init_pgtable is that big..

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/