linux-kernel - Re: [RESEND][PATCH -mm 1/2] vfs: fix coding style at dcache.c.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080623190705.04cedae2.akpm@linux-foundation.org>
Date:	Mon, 23 Jun 2008 19:07:05 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Kentaro Makita <k-makita@...css.fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	viro@...IV.linux.org.uk, harvey.harrison@...il.com
Subject: Re: [RESEND][PATCH -mm 1/2] vfs: fix coding style at dcache.c.

On Tue, 24 Jun 2008 10:45:14 +0900 Kentaro Makita <k-makita@...css.fujitsu.com> wrote:

> o fix coding style at dcache.c. No behavior changed.
> 
> Signed-off-by: Kentaro Makita <k-makita@...css.fujitsu.com>
> ---
>  fs/dcache.c |   21 ++++++++++-----------
>  1 files changed, 10 insertions(+), 11 deletions(-)
> 
> Index: b/fs/dcache.c
> ===================================================================
> --- a/fs/dcache.c	2008-06-05 11:44:26.000000000 +0900
> +++ b/fs/dcache.c	2008-06-05 11:48:57.000000000 +0900
> @@ -453,15 +453,15 @@ static void __shrink_dcache_sb(struct su
>  	int cnt = 0;
> 
>  	BUG_ON(!sb);
> -	BUG_ON((flags & DCACHE_REFERENCED) && count == NULL);
> +	BUG_ON((flags & DCACHE_REFERENCED) && !count);

A change like this isn't really a "fix".  Both styles are acceptable
and some people prefer the longer form.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/