linux-kernel - RE: [PATCH][resubmit] HP iLO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CF70AA892F109448AEA269483B3A983903B70747D5@G1W1215.americas.hpqcorp.net>
Date:	Tue, 24 Jun 2008 04:05:16 +0000
From:	"Altobelli, David" <david.altobelli@...com>
To:	Pekka Enberg <penberg@...helsinki.fi>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"greg@...ah.com" <greg@...ah.com>
Subject: RE: [PATCH][resubmit] HP iLO driver

Pekka Enberg wrote:
>
> The upper case Q is not a proper local variable name (appears
> elsewhere as well).

Okay.

> Static inline functions are preferred over function-like macros.

I'll look at those.  I like macros, but if people feel strongly about
it, I'll convert them.  The ones that shift bits around seem like
macros, but the ones that make function calls should be functions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/