linux-kernel - Re: [PATCH] input: driver for USB VoIP phones with CM109 chipset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080624045919.GA18612@anvil.corenet.prv>
Date:	Tue, 24 Jun 2008 00:59:19 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	"Alfred E. Heggestad" <aeh@...org>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: driver for USB VoIP phones with CM109 chipset

Hi Alfred,

On Sun, Jun 22, 2008 at 12:23:33AM +0200, Alfred E. Heggestad wrote:
> Hi Dmitry
>
> Dmitry Torokhov wrote:
>> Hi Alfred,
>>
>> On Thu, Feb 07, 2008 at 07:38:10PM +0100, Alfred E. Heggestad wrote:
>>> From: Alfred E. Heggestad <aeh@...org>
>>>
>>> This driver adds support for USB VoIP phones using the CM109 chipset,
>>> such as Komunikate KIP-1000 and Genius G-talk. Keypad is scanned and
>>> events are reported to the input subsystem. The buzzer can be activated
>>> by sending SND_TONE or SND_BELL to the input device. The phone keymap
>>> can be selected in run-time by using the "phone" module parameter.
>>> The driver has been tested with linux 2.6.24 on i386, and also tested
>>> to build cleanly on AMD64.
>>> More testing and code review is welcome..
>>>
>>
>> For a long time I was sitting on the patch not sure what to do about
>> the pound key, but I think we need to allocate separate keycodes for
>> remote controls and phones that work regardless of users keymap.
>>
>
> do you think we could add a new KEY_KPPOUND to include/linux/input.h ?
>
> I just had a quick look in latest git, but could not find anything..
> do you want me to define a key and make a patch for you?
>
I was pretty sure I have commited that patch a few weeks ago but I was
wrong. Anyway, please take a look at the master branch of my input tree
on git.kernel.org, it has a few new keycode definitions I woudl like us
to start using.

> BTW, for now I have defined a work-around in my cm109 driver:
>
> #ifndef KEY_KPPOUND
> #define KEY_KPPOUND (KEY_LEFTSHIFT | KEY_3 << 8)
> #endif
>
> that hack was "copied" from drivers/input/misc/yealink.c
>
>         case 0x32: return KEY_LEFTSHIFT |
>                           KEY_3 << 8;   /*   #          */
>

Yeah, well, sometimes we let suboptimal solutions sneak in... our fault.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/