linux-kernel - Re: [PATCH] module: make symbol_put_addr() work for all exported symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.10.0806251034330.4593@jikos.suse.cz>
Date:	Wed, 25 Jun 2008 10:37:37 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Rusty Russell <rusty@...tcorp.com.au>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, llipavsky@...e.cz
Subject: Re: [PATCH] module: make symbol_put_addr() work for all exported
 symbols

On Mon, 23 Jun 2008, Rusty Russell wrote:

>    It might be better to centralize all these iterators, and create a 
> proper iterator function.  Any chance you could rewrite it on top of 
> this patch? (Lightly tested)

Hi Rusty,

yes, this looks like better approach. I will respin that patch.

> +struct find_symbol_arg
> +{
> +	/* Input */
> +	const char *name;
> +	bool gplok;
> +	bool warn;
> +
> +	/* Output */
> +	struct module *owner;
> +	const unsigned long *crc;
> +	unsigned long value;
> +};

I see two options how to do this -- either I can make 'value' input 
parameter too, so that find_symbol_in_section() could perform lookup 
either according to address or according to name (whatever is specified in 
the passed struct find_symbol_arg), or I can do a completely new lookup 
function for address-wise lookups. What would you prefer? I don't have any 
strong preference either way.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/