linux-kernel - Removal of BAST IDE driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Jun 2008 10:09:53 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>, jgarzik@...ox.com,
	bzolnier@...il.com
Cc:	Linux Kernel List <linux-kernel@...r.kernel.org>,
	ben-linux@...ff.org
Subject: Removal of BAST IDE driver

Referring to this commit in mainline:

commit ac1623625c5818bbdf5c68973098ba386ba7a004
Author: Ben Dooks <ben-linux@...ff.org>
Date:   Fri Jun 20 20:53:35 2008 +0200

    BAST: Remove old IDE driver

    Remove the old BAST IDE driver, as we are now using the platform-pata
    support.

    Signed-off-by: Ben Dooks <ben-linux@...ff.org>
    Cc: Jeff Garzik <jgarzik@...ox.com>
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

I've recieved a couple of patches for the next merge window from Ben
which say:

>  Subject: [patch 20/32] BAST/VR1000: Move to using ata_platform (libata)
>
>  Use the pata_platform driver to provide the IDE port
>  drivers on the Simntec BAST and Thorcom VR1000 machines
>  as a precursor to removing drivers/ide/arm/bast-ide.c

And when I queried Ben on this, he responded thusly:

09:58 < fluffy> yes, bart was rather quicker at applying the removal patch
09:59 < fluffy> i send 'for next kernel release' and he shoved it in his -rc6
                sub

So, quite clearly we have a regression - we have platforms which have
lost IDE support.

There's two ways to resolve this.  Either the above commit can be
reverted restoring old IDE support, or the patches to add libata
support for these platforms can be submitted.  Given where we are in
the -rc, I think reverting the bad commit would be more sensible.

The question also has to be asked - what are maintainers doing putting
driver removals into -rc kernels?  Surely they are only merge-window
candidates?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/