[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4861A5DF.5010104@zytor.com>
Date: Tue, 24 Jun 2008 18:56:47 -0700
From: "H. Peter Anvin" <hpa@...or.com>
To: Paul Jackson <pj@....com>
CC: Yinghai Lu <yhlu.kernel@...il.com>, akpm@...ux-foundation.org,
mingo@...e.hu, tglx@...utronix.de, steiner@....com, travis@....com,
linux-kernel@...r.kernel.org, ying.huang@...el.com,
andi@...stfloor.org
Subject: Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal
in some kernel info printks
Paul Jackson wrote:
> Yinghai wrote:
>> Zone PFN ranges:
>> DMA 0x 0 -> 0x 1000
>
> Aha - you're right!
>
> I just earned the Ugly Patch of the Day Award.
>
> I think changes of "%lu" to "0x%lx" are still ok,
> but changes of "%8lu" to "0x%8lx" (which use 8
> columns, right aligned, space filled format) are
> not ok.
>
No, that would have to be %#10lx.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists