linux-kernel - Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal in some kernel info printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4861AAEF.3020103@zytor.com>
Date:	Tue, 24 Jun 2008 19:18:23 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Paul Jackson <pj@....com>
CC:	yhlu.kernel@...il.com, akpm@...ux-foundation.org, mingo@...e.hu,
	tglx@...utronix.de, steiner@....com, travis@....com,
	linux-kernel@...r.kernel.org, ying.huang@...el.com,
	andi@...stfloor.org
Subject: Re: [PATCH 4/5 v2] x86 boot: show pfn addresses in hex not decimal
 in some kernel info printks

Paul Jackson wrote:
> hpa wrote:
>> that would have to be %#10lx.
> 
> Hmmm ... the '#' is a good idea, instead of an explicit "0x".
> 
> Do we want zero padding as well, with "0#8lx" ?
> 
> Zone PFN ranges:
>   DMA      0x00000000 -> 0x00001000
>   DMA32    0x00001000 -> 0x00100000
>   Normal   0x00100000 -> 0x00428000
> 
> or right aligned, space padded:
> 
> Zone PFN ranges:
>   DMA             0x0 ->     0x1000
>   DMA32        0x1000 ->   0x100000
>   Normal     0x100000 ->   0x428000
> 
> I like the zero padding here myself.
> 

Yes, zero padding.

What we really should have is %p produce this format.  For some odd 
reason, right now %p produces numbers without the 0x prefix.

	-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/