linux-kernel - Re: [PATCH 2/3] e820_update_range(): Allow specifying ULLONG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080625154459.GD18796@elte.hu>
Date:	Wed, 25 Jun 2008 17:44:59 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Bernhard Walle <bwalle@...e.de>
Cc:	Yinghai Lu <yhlu.kernel@...il.com>, x86@...nel.org,
	vgoyal@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX


* Bernhard Walle <bwalle@...e.de> wrote:

> * Yinghai Lu [2008-06-24 13:21]:
> >
> > > it seems we should let the caller to use
> > > e820_update_range(start, ULLONG_MAX - size,....)
> > >
> > > so you don't need to touch this func.
> > 
> > or add sanitary check before using size in this func like
> > if (size > ULLONG_MAX - start)
> >      size = ULLONG_MAX - start;
> > 
> > e820_remove_range need to the same thing
> 
> I like that. I think the complexity should be in the function, and not 
> in the caller's function.

ok - i'll wait for v2 of these patches, which will have the feedback 
from Yinghai incorporated - agreed? (Please Cc: Yinghai on the next 
submission of this series) Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/