linux-kernel - [PATCH] firewire: fw-sbp2: fix parsing of logical unit directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tkrat.24168af4c57c3bde@s5r6.in-berlin.de>
Date:	Wed, 25 Jun 2008 18:37:43 +0200 (CEST)
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux1394-devel@...ts.sourceforge.net,
	Kevin Valentine <kevin.valentine@...il.com>
cc:	linux-kernel@...r.kernel.org,
	Richard Sharpe <realrichardsharpe@...il.com>
Subject: [PATCH] firewire: fw-sbp2: fix parsing of logical unit directories

Date: Tue, 24 Jun 2008 19:11:13 -0700
From: Richard Sharpe <realrichardsharpe@...il.com>

There is a small off-by-one bug in firewire-sbp2. This causes problems
when a device exports multiple LUN Directories. I found it when trying
to talk to a SONY DVD Jukebox.

Signed-off-by: Richard Sharpe <realrichardsharpe@...il.com>
Acked-by: Kristian Høgsberg <krh@...hat.com>
Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de> (op. order, changelog)
---

Kevin, this bug probably prevented the detection of the second drive in
the PowerFile C200 when you tested the new drivers.

 drivers/firewire/fw-sbp2.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux/drivers/firewire/fw-sbp2.c
===================================================================
--- linux.orig/drivers/firewire/fw-sbp2.c
+++ linux/drivers/firewire/fw-sbp2.c
@@ -1066,7 +1066,8 @@ static int sbp2_scan_unit_dir(struct sbp
 			break;
 
 		case SBP2_CSR_LOGICAL_UNIT_DIRECTORY:
-			if (sbp2_scan_logical_unit_dir(tgt, ci.p + value) < 0)
+			/* Adjust for the increment in the iterator */
+			if (sbp2_scan_logical_unit_dir(tgt, ci.p - 1 + value) < 0)
 				return -ENOMEM;
 			break;
 		}

-- 
Stefan Richter
-=====-==--- -==- ==--=
http://arcgraph.de/sr/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/