linux-kernel - [patch] x86: shift bits the right way in native_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1214430328.20425.20.camel@w-amax.beaverton.ibm.com>
Date:	Wed, 25 Jun 2008 14:45:28 -0700
From:	Max Asbock <masbock@...ibm.com>
To:	gcosta@...hat.com, tglx <tglx@...utronix.de>,
	mingo <mingo@...hat.com>, hpa <hpa@...or.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [patch] x86: shift bits the right way in native_read_tscp

native_read_tscp shifts the bits in the high order value in the wrong direction,
the attached patch fixes that. 

Signed-off-by: Max Asbock <masbock@...ux.vnet.ibm.com>

diff -pburN linux/include/asm-x86/msr.h linux.rdtscp/include/asm-x86/msr.h
--- linux/include/asm-x86/msr.h	2008-06-20 11:51:17.000000000 -0700
+++ linux.rdtscp/include/asm-x86/msr.h	2008-06-25 14:26:35.000000000 -0700
@@ -18,7 +18,7 @@ static inline unsigned long long native_
 	unsigned long low, high;
 	asm volatile(".byte 0x0f,0x01,0xf9"
 		     : "=a" (low), "=d" (high), "=c" (*aux));
-	return low | ((u64)high >> 32);
+	return low | ((u64)high << 32);
 }
 
 /*


---
Max


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/