linux-kernel - Re: [PATCH] PNP: have quirk_system_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4862C3D6.4060100@keyaccess.nl>
Date:	Thu, 26 Jun 2008 00:16:54 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	bjorn.helgaas@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PNP: have quirk_system_pci_resources() include io resources.

On 25-06-08 23:46, Rene Herman wrote:

> On 25-06-08 23:16, Andrew Morton wrote:
> 
>> On Wed, 25 Jun 2008 19:58:20 +0200
>> Rene Herman <rene.herman@...access.nl> wrote:
>>
>>> +            unsigned int type;
>>> +
>>> +            type = pci_resource_flags(pdev, i) &
>>> +                    (IORESOURCE_IO | IORESOURCE_MEM);
>>
>> pci_resource_flags() returns an unsigned long.
>>
>> But I think you're right and resource.flags is wrong.  Because there's
>> no way in which we'll ever be able to use bits 32-63 of that field
>> anyway.
>>
>> I suppose that Someone(tm) should convert resource.flags to a u32 or
>> something.  Minor issue.
> 
> Yes, did notice but pnp_get_resource() then takes those same flags as an 
> unsigned int -- had to pick one or the other and "the smallest one" then 
> seemed best...

semi-arguably, the pnp_get_resource() is simply wrong though, so maybe 
this patch. After this, the quirks one should indeed be an unsigned long 
also. Bjorn?

Rene.

View attachment "0001-PNP-make-the-resource-type-an-unsigned-long.patch" of type "text/plain" (2115 bytes)