lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 25 Jun 2008 16:39:28 -0600
From:	Jonathan Corbet <corbet@....net>
To:	David Brownell <david-b@...bell.net>
Cc:	lkml <linux-kernel@...r.kernel.org>, rtc-linux@...glegroups.com,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] rtc: remove BKL for ioctl()

On Sun, 22 Jun 2008 19:55:42 -0700
David Brownell <david-b@...bell.net> wrote:

> Remove implicit use of BKL in ioctl() from the RTC framework.

Looks good, I'll happily put it into the bkl-removal tree.  One
question, though:

> +	err = mutex_lock_interruptible(&rtc->ops_lock);
> +	if (err)
> +		return -EBUSY;
> +

Shouldn't that be -EINTR?

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists