linux-kernel - Re: [PATCH 00/16] x86: merge setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080626110113.GA14513@elte.hu>
Date:	Thu, 26 Jun 2008 13:01:13 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Huang@...e.hu, Ying <ying.huang@...el.com>,
	Bjorn Helgaas <bjorn.helgaas@...com>
Subject: Re: [PATCH 00/16] x86: merge setup_32/64.c


* Yinghai Lu <yhlu.kernel@...il.com> wrote:

> >  #include <asm/mpspec.h>
> >  #include <asm/setup.h>
> >  #include <asm/arch_hooks.h>
> > +#include <asm/efi.h>
> >  #include <asm/sections.h>
> >  #include <asm/dmi.h>
> >  #include <asm/io_apic.h>
> 
> checkpatch.pl want me to remove that.

checkpatch.pl is right about that, but the proper fix would be to decode 
this dependency - why isnt it enough to include linux/efi.h?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/