linux-kernel - Re: [REGRESSION] 2.6.24/25: random lockups when accessing external USB harddrive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0806261018340.2811-100000@iolanthe.rowland.org>
Date:	Thu, 26 Jun 2008 10:25:35 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Stefan Becker <Stefan.Becker@...ia.com>
cc:	linux-kernel@...r.kernel.org, <linux-usb@...r.kernel.org>
Subject: Re: [REGRESSION] 2.6.24/25: random lockups when accessing external
 USB harddrive

On Thu, 26 Jun 2008, Stefan Becker wrote:

> Hi,
> 
> ext Alan Stern wrote:
> > On Wed, 25 Jun 2008, Stefan Becker wrote:
> > 
> >> HCD URB list locked by usb_hcd_link_urb_to_ep!
> >>
> >> As far as I understand the matter this only can happen if 
> >> usb_hcd_link_urb_to_ep() gets interrupted while holding the spinlock. 
> >> But according to the contract at the header of the function it should be 
> >> called with interrupts disabled!
> > 
> > So it should.  Do you know how to test whether interrupts are enabled?  
> > There's a routine called raw_irqs_disabled() defined in 
> > include/asm/irqflags.h.  Stick it inside usb_hcd_link_urb_to_ep, and 
> > the first time it returns nonzero, do a dump_stack().

Typo: I should have said "the first time it returns zero..."

Do you have any of the RT patches installed?

> Tried both and got nothing. So either our reasoning is wrong or 
> something really weird is going on. I'll try to improve my debugging 
> code and use dump_stack() at the place where it locks up.

Well, it would be pretty surprising if spin_lock_irq or 
spin_lock_irqsave were misbehaving.

Something else you should try is clearing your "owner" string just
before the spinlock is released.  You could also add a check after the
release; if the spinlock can't be locked again immediately then
something is wrong.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/