[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <alpine.LFD.1.10.0806252345460.3279@localhost.localdomain>
Date: Wed, 25 Jun 2008 23:48:32 -0400 (EDT)
From: Len Brown <lenb@...nel.org>
To: Bjorn Helgaas <bjorn.helgaas@...com>
Cc: Jesse Barnes <jbarnes@...tuousgeek.org>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>, linux-acpi@...r.kernel.org,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 5/5] x86 PCI: use dev_printk when possible
I guess the 'INTA#; rather than 'INTA' syntax I'm not fond of appears in
this x86 patch too. I think if we don't really have anything useful
to say about polarity, then we should not add an active low symbol.
thanks,
-Len
- printk(KERN_INFO "PCI: %s IRQ %d for device %s\n", msg, irq,
pci_name(dev));
+ dev_info(&dev->dev, "%s PCI INT%c# -> IRQ %d\n", msg, 'A' + pin,
irq);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists