linux-kernel - Re: [PATCH] usb: fix uninitialized variables in keyspan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080627095816.4b9c8a2e@lxorguk.ukuu.org.uk>
Date:	Fri, 27 Jun 2008 09:58:16 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Benny Halevy <bhalevy@...asas.com>
Cc:	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org,
	Benny Halevy <bhalevy@...asas.com>
Subject: Re: [PATCH] usb: fix uninitialized variables in keyspan_pda

On Fri, 27 Jun 2008 10:58:54 +0300
Benny Halevy <bhalevy@...asas.com> wrote:

> The compiler (gcc 4.3.0) warns that status might be used uninitialized
> in keyspan_pda_tiocmget and keyspan_pda_tiocmset.
> 
> It is technically correct and therefore this patch initializes
> status to 0 in both cases.
> 
> Note that keyspan_pda_get_modem_info sets *value only when
> usb_control_msg returns rc > 0, otherwise it must
> return an error rc < 0, and it must never return rc == 0, hence
> a WARN_ON(rc == 0) was added in case usb_control_msg ever return 0.

That seems like overkill - and by forcing status to 0 you will hide
future gcc error catches. Far better to change the two callers to test
for > 0 not >= 0 surely ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/