linux-kernel - Re: [PATCH -tip/master] x86: nmi_watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Jun 2008 20:51:25 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Chris Friesen <cfriesen@...tel.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip/master] x86: nmi_watchdog - documentation fix

[Chris Friesen - Fri, Jun 27, 2008 at 10:32:12AM -0600]
> Alan Cox wrote:
>> On Fri, 27 Jun 2008 16:54:19 +0100 (BST)
>> "Maciej W. Rozycki" <macro@...ux-mips.org> wrote:
>>> On Fri, 27 Jun 2008, Cyrill Gorcunov wrote:
>>>
>>>
>>>> +NOTE: Prior to 2.4.2-ac18 the NMI-oopser is enabled unconditionally
>>>> +on x86 SMP boxes.
>>>
>>> While you are at it: s/is/was/.
>> Erm - why ??
>> It is still true today that kernels < 2.4.2-ac8 have the NMI oopser
>> enabled.
>
> To my ear the phrase as written implies past tense for the author/reader 
> (i.e. "at points in time prior to the release of 2.4.2-ac18"), and thus 
> grates against "is".
>
> The following sounds better to me: "In kernels prior to 2.4.2-ac18 the 
> NMI-oopser is enabled..."  In this context the phrase itself is in the 
> present, but we point to past kernels.
>
> Chris
>

And the winner is? I'm not native English speaker so I can't select
a better candidate in {is,was} limited set.

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/