[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200806271315.01148.jbarnes@virtuousgeek.org>
Date: Fri, 27 Jun 2008 13:14:59 -0700
From: Jesse Barnes <jbarnes@...tuousgeek.org>
To: Adrian Bunk <bunk@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
dhowells@...hat.com, gerg@...inux.org, ralf@...ux-mips.org,
linux-mips@...ux-mips.org, lethal@...ux-sh.org,
linux-sh@...r.kernel.org, Russell King <rmk+lkml@....linux.org.uk>
Subject: Re: [2.6 patch] remove pcibios_update_resource() functions
On Tuesday, June 17, 2008 3:33 pm Adrian Bunk wrote:
> Russell King did the following back in 2003:
>
> <-- snip -->
>
> [PCI] pci-9: Kill per-architecture pcibios_update_resource()
>
> Kill pcibios_update_resource(), replacing it with
> pci_update_resource(). pci_update_resource() uses pcibios_resource_to_bus()
> to convert a resource to a device BAR - the transformation should be
> exactly the same as the transformation used for the PCI bridges.
>
> pci_update_resource "knows" about 64-bit BARs, but doesn't attempt to
> set the high 32-bits to anything non-zero - currently no architecture
> attempts to do something different. If anyone cares, please fix; I'm
> going to reflect current behaviour for the time being.
>
> Ivan pointed out the following architectures need to examine their
> pcibios_update_resource() implementation - they should make sure that
> this new implementation does the right thing. #warning's have been
> added where appropriate.
>
> ia64
> mips
> mips64
>
> This cset also includes a fix for the problem reported by AKPM where
> 64-bit arch compilers complain about the resource mask being placed
> in a u32.
>
> <-- snip -->
>
>
> This patch removes the unused pcibios_update_resource() functions the
> kernel gained since.
>
>
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
Applied to my linux-next tree, thanks Adrian and everyone for your acks.
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists