linux-kernel - Re: [PATCH 1/3] mmc: Export internal host state through debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080628154015.423daf51@mjolnir.drzeus.cx>
Date:	Sat, 28 Jun 2008 15:40:15 +0200
From:	Pierre Ossman <drzeus-mmc@...eus.cx>
To:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] mmc: Export internal host state through debugfs

On Sat, 28 Jun 2008 15:37:04 +0200
Haavard Skinnemoen <haavard.skinnemoen@...el.com> wrote:

> Pierre Ossman <drzeus-mmc@...eus.cx> wrote:
> > 
> > In the other places we have conditional function, it is done by
> > ifdef:ing the calls instead. There are just two of them, so it should
> > be less mess.
> 
> Hmm. You mean it's better with three #ifdefs than one?
> 

Fewer lines though. Those dummy function stick out like a sore thumb.
It's a decent trade-off when you have multiple callers, but here we have
just the one.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/