| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080628162312.0f10c6d3@hskinnemo-gx745.norway.atmel.com> Date: Sat, 28 Jun 2008 16:23:12 +0200 From: Haavard Skinnemoen <haavard.skinnemoen@...el.com> To: Pierre Ossman <drzeus-mmc@...eus.cx> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] mmc: Export internal host state through debugfs Pierre Ossman <drzeus-mmc@...eus.cx> wrote: > > Hmm. You mean it's better with three #ifdefs than one? > > > > Fewer lines though. Those dummy function stick out like a sore thumb. > It's a decent trade-off when you have multiple callers, but here we have > just the one. Actually, if debugfs is disabled, debugfs_create_dir() and friends are inline functions which return ERR_PTR(-ENODEV). So if we just remove the whole #ifdef altogether, gcc should be smart enough to optimize away the whole thing if debugfs isn't enabled... I'll give it a try. Haavard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists