linux-kernel - Re: [REGRESSION] 2.6.24/25: random lockups when accessing external USB harddrive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0806281241200.23326-100000@netrider.rowland.org>
Date:	Sat, 28 Jun 2008 12:53:00 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Stefan Becker <Stefan.Becker@...ia.com>
cc:	linux-kernel@...r.kernel.org, <linux-usb@...r.kernel.org>
Subject: Re: [REGRESSION] 2.6.24/25: random lockups when accessing external
 USB harddrive

On Sat, 28 Jun 2008, Stefan Becker wrote:

> Second try, slightly different tack: no dump_stack() in the _irq() 
> functions, but disabled/enabled indication. Plus debugging code added in 
> usb_hcd_add() to see the interrupt registration. Again too much data was 
> printed for the bug to appear.
> 
> Looking at the collected data it looks like
> 
>   - ehci_irq() is always entered with interrupts enabled (WRONG).
> 
>   - uhci_irq() is entered sometimes with either interrupts enabled 
> (WRONG) or disabled (OK).
> 
> But both interrupts are registered with IRQF_DISABLED...

It certainly looks like you've found a flaw in the core kernel.  Or 
else a subtle hardware flaw in your CPU...

Just to be certain, take out all your new code and instead add a simple 
test at the start of usb_hcd_irq() in hcd.c.  That routine is the 
registered handler for USB interrupts.  If interrupts are ever enabled 
at that spot, then something is badly wrong.

You might also keep track of the total number of each type of call, so
whenever you find interrupts are enabled, you can print out something
like this:

	usb_hcd_irq(): interrupts disabled %d, enabled %d

where the two values are the numbers of times the routine has been 
called with interrupts off or on, respectively.  You don't have to run 
this for a long time; since the test code should _never_ trigger, any 
output at all will indicate a real problem.

When you get that, change the Subject of your email to make it more 
noticeable.  A line like:

	BUG in 2.6.26-rc8 interrupt handling!

should draw people's attention.  :-)  Include a description of the 
problem and a copy of /proc/interrupts.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/