linux-kernel - Re: [v4l-dvb-maintainer] [PATCH] add Sensoray 2255 v4l driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080628214335.40185450@gaivota>
Date:	Sat, 28 Jun 2008 21:43:35 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	hermann pitton <hermann-pitton@...or.de>
Cc:	Greg KH <greg@...ah.com>, v4l-dvb-maintainer@...uxtv.org,
	linux-usb@...r.kernel.org, dean@...soray.com,
	video4linux-list@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [v4l-dvb-maintainer] [PATCH] add Sensoray 2255 v4l driver

Hi Hermann,

On Sun, 29 Jun 2008 00:08:34 +0200
hermann pitton <hermann-pitton@...or.de> wrote:


> On an attempt to get recent drivers on a FC8 x86_64 machine to watch
> Glastonbury music festival on BBC HD DVB-S with the saa714 driver on an
> recently updated 2.6.25 FC kernel it also fails to compile on some
> strlcpy attempt. Same with a 2.6.24 on the mail machine here.
> 
>   CC [M]  /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/quickcam_messenger.o
>   CC [M]  /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.o
> /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c: In function 'vidioc_querycap':
> /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c:809: error: implicit declaration of function 'dev_name'
> /mnt/xfer/mercurial/v4l-dvb-head/v4l-dvb/v4l/s2255drv.c:809: warning: passing argument 2 of 'strlcpy' makes pointer from integer without a cast

The code is not backward compatible. It works only with 2.6.27-rc.

I'll add the macro ballow at compat.h to allow its out of tree compilation:

#define dev_name(dev)  ((dev)->bus_id)

This simple macro worked fine with 2.6.25.6.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/