lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 29 Jun 2008 10:32:43 +0300 From: Benny Halevy <bhalevy@...asas.com> To: Jeff Dike <jdike@...toit.com> CC: user-mode-linux-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] fix extern inline errors with gcc 4.3.0 On Jun. 28, 2008, 16:10 +0300, "Halevy, Benny" <bhalevy@...asas.com> wrote: > On Fri 2008-06-27 19:26, Jeff Dike <jdike@...toit.com> wrote: >> On Thu, Jun 26, 2008 at 04:50:51PM +0300, Benny Halevy wrote: >>> -KBUILD_CFLAGS += $(call cc-option,-fno-unit-at-a-time,) >>> +# Disable unit-at-a-time mode on pre-gcc-4.3 compilers, it makes gcc use >>> +# a lot more stack due to the lack of sharing of stacklots: >>> +# gcc 4.3.0 needs -funit-at-a-time for extern inline functions >>> +KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0403 ] ; then \ >>> + echo $(call cc-option,-fno-unit-at-a-time); fi ;) >> How do we know that this patch won't cause the same crash reported in >> http://marc.info/?l=linux-kernel&m=121011722806093&w=2? Note that the crash happened with gcc 4.1.2 and it will get the -fno-unit-at-a-time flag with the proposed patch. That said, this option or the lack of it ought not to cause any runtime crashes. If it does, I'd feel much more comfortable to know exactly what the root cause is before deciding to use the flag to workaround^hide it. Benny > > I don't know what was the root cause for the crash you mentioned. > FWIW, with these options UML/x86_64 builds on Fedora 9, w/ gcc 4.3.0 > and runs well for me. > > Benny > >> Jeff >> >> -- >> Work email - jdike at linux dot intel dot com >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists