linux-kernel - Re: [PATCH V2] Keep 3 high personality bytes across exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jun 2008 18:19:40 +1000
From:	Paul Mackerras <paulus@...ba.org>
To:	Eric B Munson <ebmunson@...ibm.com>
Cc:	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] Keep 3 high personality bytes across exec

Eric B Munson writes:

> --- a/include/asm-powerpc/elf.h
> +++ b/include/asm-powerpc/elf.h
> @@ -257,7 +257,8 @@ do {								\
>  	else							\
>  		clear_thread_flag(TIF_ABI_PENDING);		\
>  	if (personality(current->personality) != PER_LINUX32)	\
> -		set_personality(PER_LINUX);			\
> +		set_personality(PER_LINUX |			\
> +			(current->personality & PER_INHERIT));	\

Couldn't we use ~PER_MASK here instead of PER_INHERIT?  That would
mean we wouldn't have to modify include/linux/personality.h, and we
wouldn't have to keep updating PER_INHERIT as more flags get added.

(Nice patch description, BTW.  Thanks.)

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/