linux-kernel - Re: [PATCH 13/13] viafb: via_utility.c, via

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080630104407.6adf59ab@lxorguk.ukuu.org.uk>
Date:	Mon, 30 Jun 2008 10:44:07 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	<JosephChan@....com.tw>
Cc:	<JosephChan@....com.tw>, <linux-fbdev-devel@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>, <akpm@...ux-foundation.org>,
	<geert@...ux-m68k.org>
Subject: Re: [PATCH 13/13] viafb: via_utility.c, via_utility.h, vt1636.c,
 vt1636.h

> +void get_gamma_table(unsigned int *gamma_table)

Still more globals with names asking to cause clashes

> +{
> +	unsigned char color_r[256];
> +	unsigned char color_g[256];
> +	unsigned char color_b[256];
> +	unsigned char sr1a = 0;

and possibly excesive stack usage


I think at this point however the code is in a state where it would be
more productive to merge it and then fix up the remaining smaller details
than keep going round back to VIA to change it internally and return.

So

Acked-by: Alan Cox <alan@...hat.com>  - for the patch series, subject to
further tidyups getting done after it is all merged.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/