linux-kernel - Re: [patch] x86: add compilation checks to pci_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080630102332.GC31497@elte.hu>
Date:	Mon, 30 Jun 2008 12:23:32 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Matti Linnanvuori <mattilinn@...il.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] x86: add compilation checks to pci_unmap_ macros


* Matti Linnanvuori <mattilinn@...il.com> wrote:

> From: Matti Linnanvuori <mattilinnanvuori@...oo.com>
> 
> Add compilation checks to pci_unmap_ macros.

> -#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME)
> -#define DECLARE_PCI_UNMAP_LEN(LEN_NAME)
> -#define pci_unmap_addr(PTR, ADDR_NAME)		(0)
> -#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL)	do { } while (0)
> -#define pci_unmap_len(PTR, LEN_NAME)		(0)
> -#define pci_unmap_len_set(PTR, LEN_NAME, VAL)	do { } while (0)
> +#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME)	dma_addr_t ADDR_NAME[0];
> +#define DECLARE_PCI_UNMAP_LEN(LEN_NAME)	unsigned LEN_NAME[0];
> +#define pci_unmap_addr(PTR, ADDR_NAME)	sizeof((PTR)->ADDR_NAME)
> +#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL) \
> +	do { break; } while (pci_unmap_addr(PTR, ADDR_NAME))
> +#define pci_unmap_len(PTR, LEN_NAME)		sizeof((PTR)->LEN_NAME)
> +#define pci_unmap_len_set(PTR, LEN_NAME, VAL) \
> +	do { break; } while (pci_unmap_len(PTR, LEN_NAME))

applied to tip/x86/cleanups - thanks Matti.

Would you be interested in doing a small cleanup as well and convert the 
parameter names to non-shouting lower-case letters? (If you do it then 
please do it as a delta patch as i've already applied your current 
patch.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/