linux-kernel - Re: [PATCH 02/34] AMD IOMMU: add header file for driver data structures and defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080630122208.GC25092@elte.hu>
Date:	Mon, 30 Jun 2008 14:22:08 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	joerg.roedel@....com, tglx@...utronix.de, mingo@...hat.com,
	linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
	bhavna.sarathy@....com, Sebastian.Biemueller@....com,
	robert.richter@....com, joro@...tes.org
Subject: Re: [PATCH 02/34] AMD IOMMU: add header file for driver data
	structures and defines


* FUJITA Tomonori <fujita.tomonori@....ntt.co.jp> wrote:

> > > > Signed-off-by: Joerg Roedel <joerg.roedel@....com>
> > > > ---
> > > >  include/asm-x86/amd_iommu_types.h |  242 +++++++++++++++++++++++++++++++++++++
> > > >  1 files changed, 242 insertions(+), 0 deletions(-)
> > > >  create mode 100644 include/asm-x86/amd_iommu_types.h
> > > 
> > > Is necessary to make this file visible to everyone by putting this in
> > > include/asm?
> > 
> > The alternative was to put this file in arch/x86/kernel/. But I don't
> > think its the right place for include files. We have include/ for that.
> 
> Hmm, really? It's the right thing in the SCSI subsystem at least. You 
> don't need to put a header file having only private stuff in include/.

it's OK to have it in include/asm-x86/ (in fact i'd prefer it to stay 
there). It includes hardware API details, etc.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/