linux-kernel - Re: [PATCH 26/34] AMD IOMMU: add mapping functions for scatter gather lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080630132545.GP1303@amd.com>
Date:	Mon, 30 Jun 2008 15:25:45 +0200
From:	Joerg Roedel <joerg.roedel@....com>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
CC:	tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org,
	iommu@...ts.linux-foundation.org, bhavna.sarathy@....com,
	Sebastian.Biemueller@....com, robert.richter@....com,
	joro@...tes.org
Subject: Re: [PATCH 26/34] AMD IOMMU: add mapping functions for scatter gather lists

On Mon, Jun 30, 2008 at 12:07:16AM +0900, FUJITA Tomonori wrote:
> On Thu, 26 Jun 2008 21:28:02 +0200
> Joerg Roedel <joerg.roedel@....com> wrote:
> 
> > This patch adds the dma_ops functions for mapping and unmapping scatter gather
> > lists.
> > 
> > Signed-off-by: Joerg Roedel <joerg.roedel@....com>
> > ---
> >  arch/x86/kernel/amd_iommu.c |   98 +++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 98 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
> > index b4079f6..f4747fe 100644
> > --- a/arch/x86/kernel/amd_iommu.c
> > +++ b/arch/x86/kernel/amd_iommu.c
> > @@ -700,3 +700,101 @@ static void unmap_single(struct device *dev, dma_addr_t dma_addr,
> >  	spin_unlock_irqrestore(&domain->lock, flags);
> >  }
> >  
> > +static int map_sg_no_iommu(struct device *dev, struct scatterlist *sglist,
> > +			   int nelems, int dir)
> > +{
> > +	struct scatterlist *s;
> > +	int i;
> > +
> > +	for_each_sg(sglist, s, nelems, i) {
> > +		s->dma_address = (dma_addr_t)sg_phys(s);
> > +		s->dma_length  = s->length;
> > +	}
> > +
> > +	return nelems;
> > +}
> > +
> > +static int map_sg(struct device *dev, struct scatterlist *sglist,
> > +		  int nelems, int dir)
> > +{
> > +	unsigned long flags;
> > +	struct amd_iommu *iommu;
> > +	struct protection_domain *domain;
> > +	u16 devid;
> > +	int i;
> > +	struct scatterlist *s;
> > +	phys_addr_t paddr;
> > +	int mapped_elems = 0;
> > +
> > +	get_device_resources(dev, &iommu, &domain, &devid);
> > +
> > +	if (!iommu || !domain)
> > +		return map_sg_no_iommu(dev, sglist, nelems, dir);
> 
> VT-d put a pointer in struct dev_archdata to store IOMMU info per
> device. Is is useful for you too?

Hmm yes. Thank you for that hint. I can save at least one of my arrays
with that method.

Joerg


-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/