linux-kernel - Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0806301035510.2708-100000@iolanthe.rowland.org>
Date:	Mon, 30 Jun 2008 10:37:27 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	David Brownell <david-b@...bell.net>
cc:	Stefan Becker <Stefan.Becker@...ia.com>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	ext Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: PATCH: 2.6.26-rc8: Fix IRQF_DISABLED for shared interrupts

On Mon, 30 Jun 2008, David Brownell wrote:

> On Monday 30 June 2008, Stefan Becker wrote:
> > It seems IRQF_SHARED | IRQF_DISABLED has already been discussed several 
> > times on LKML:
> 
> Given that, I'm surprised that nobody has added a warning that
> prints when those two flags are both passed to request_irq().
> 
> The problems have been around for a long time, "tested" and known
> to be broken.  They'll never go away without nag messages nudging
> developers to fix the problems.
> 
> 
> > Alan: should I try to implement his choice (f) insteadn, i.e. drop 
> > IRQF_DISABLED from USB HCD interrupts and disable interrupts in 
> > usb_hcd_irq() instead?
> 
> That's the best solution for USB, given that IRQF_DISABLED isn't
> going to do what it claims to do.

I agree.  Note that IRQF_DISABLED is used in hcd_pci.c as well as in
quite a few files in drivers/usb/host.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/