[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080630161537.GD8489@trinity.fluff.org>
Date: Mon, 30 Jun 2008 17:15:37 +0100
From: Ben Dooks <ben-linux@...ff.org>
To: Pierre Ossman <drzeus-mmc@...eus.cx>
Cc: Ben Dooks <ben-linux@...ff.org>, linux-kernel@...r.kernel.org,
tk@...ntech.de, laforge@...nmoko.org
Subject: Re: [patch v4 02/17] MMC: S3C24XX: Fix the checkpatch.pl errors in the s3cmci driver
On Mon, Jun 30, 2008 at 05:50:18PM +0200, Pierre Ossman wrote:
> On Mon, 30 Jun 2008 16:25:49 +0100
> Ben Dooks <ben-linux@...ff.org> wrote:
>
> > Fix the checkpatch and other problems pointed out by
> > akpm.
> >
> > Signed-off-by: Ben Dooks <ben-linux@...ff.org>
> >
>
> I prefer to have this one merged into 01 as you'll end up with a commit
> that you cannot compile otherwise. Besides, running checkpatch is
> something you do before submitting anyway, not as a separate cleanup. :)
In this case I kept it seperate as the cleanups where done by myself
as the original driver authour is not interested or too busy to do
these himself. Basically, I was trying to keep the driver and my own
cleanup work seperate.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists