linux-kernel - Re: [PATCH] USB: fix interrupt disabling for HCDs with shared interrupt handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0806301532500.2138-100000@iolanthe.rowland.org>
Date:	Mon, 30 Jun 2008 15:35:25 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Stefan Becker <Stefan.Becker@...ia.com>
cc:	David Brownell <david-b@...bell.net>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	ext Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] USB: fix interrupt disabling for HCDs with shared
 interrupt handlers

On Mon, 30 Jun 2008, Stefan Becker wrote:

> Hi,
> 
> here is the proposed patch to fix the problem. I hope I used git 
> correctly to generate it...

> This patch doesn't modify the interface of usb_add_hcd(), i.e. HCD code
> can still use IRQF_DISABLED. It will now silently convert this into an
> internal HCD flag and clear IRQF_DISABLED before requesting the interrupt
> from the Linux core. usb_hcd_irq() will check this flag to disable/re-enable
> the interrupts on a case by case basis.

Don't bother with this extra stuff.  All USB host controller drivers
want to have interrupts disabled when their IRQ handlers run.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/