linux-kernel - Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080630.124641.13641106.davem@davemloft.net>
Date:	Mon, 30 Jun 2008 12:46:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	chas@....nrl.navy.mil
Cc:	dwmw2@...radead.org, netdev@...r.kernel.org,
	linux-atm-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM
 driver to request_firmware()

From: "Chas Williams (CONTRACTOR)" <chas@....nrl.navy.mil>
Date: Mon, 30 Jun 2008 12:10:47 -0400

> In message <1214837678.10393.345.camel@...c.infradead.org>,David Woodhouse writ
> es:
> >> i removed the #ifdef's from around MODULE_LICENSE().  there shouldnt
> >> be any need for #ifdef's around MODULE_FIRMWARE() either.
> >
> >Unless you put #ifdef CONFIG_SBUS around the
> >MODULE_FIRMWARE("sba200e_ecd.bin") you will be requesting that firmware
> >even on non-sbus machines. Likewise little-endian vs. big-endian on PCI.
> 
> does it?  i was under the impression that MODULE_FIRMWARE() just
> provides a hint that modinfo can read.  request_firmware() still
> the requestor for the firmware image.

And also, there are systems with both PCI and SBUS so we should
make sure we handle that properly here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/