linux-kernel - Re: [PATCH 15/39] don't save ebx in putuser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4869458D.9060603@redhat.com>
Date:	Mon, 30 Jun 2008 17:43:57 -0300
From:	Glauber Costa <gcosta@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...e.hu,
	x86@...nel.org
Subject: Re: [PATCH 15/39] don't save ebx in putuser_32.S

Andi Kleen wrote:
> Glauber Costa <gcosta@...hat.com> writes:
> 
>> clobber it in the inline asm macros, and let the compiler do this for us.
> 
> I would expect that definitely will cause code size regressions ...
> 
> -Andi

Andi,

Thanks for reviewing my patches.

Although I agree with you, I think the reduced codesize is not enough a 
reason to keep code duplicated. If you can provide a version of it that 
is granted to reduce the code size for both i386 and x86_64, or even one 
that makes it minimal for x86_64 and yet, works with i386, fine.

Otherwise, I still think this is the best option.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/