linux-kernel - Re: [PATCH] ptrace GET/SET FPXREGS broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080630210245.8BA76154077@magilla.localdomain>
Date:	Mon, 30 Jun 2008 14:02:45 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	TAKADA Yoshihito <takada@....nifty.com>
Cc:	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] ptrace GET/SET FPXREGS broken

Thanks for the report.  That was indeed a regression from 2.6.24 in ptrace.
To match traditional behavior, ptrace should only ever return -EIO for all
kinds of errors accessing registers (except for the -ESRCH cases).  But it
is cleaner for the user_regset calls to use meaningful error codes, and
-ENODEV is what makes sense for the !cpu_has_fxsr case.
So the right fix for this is in ptrace, not in user_regset.

Ingo, please revert takada's patch and apply the one about to come from me.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/