linux-kernel - Re: [PATCH] PCI: add stub for pci_set_consistent_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200806302310.12478.mb@bu3sch.de>
Date:	Mon, 30 Jun 2008 23:10:12 +0200
From:	Michael Buesch <mb@...sch.de>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>, linux-pci@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>,
	jejb <James.Bottomley@...senpartnership.com>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH] PCI: add stub for pci_set_consistent_dma_mask()

On Monday 30 June 2008 23:00:02 Jesse Barnes wrote:
> On Monday, June 30, 2008 1:40 pm Michael Buesch wrote:
> > On Monday 30 June 2008 20:42:30 Jesse Barnes wrote:
> > > On Monday, June 30, 2008 11:35 am Randy Dunlap wrote:
> > > > From: Randy Dunlap <randy.dunlap@...cle.com>
> > > >
> > > > When CONFIG_PCI=n, there is no stub for pci_set_consistent_dma_mask(),
> > > > so add one like other similar stubs.  Otherwise there can be build
> > > > errors, as here:
> > > >
> > > > linux-next-20080630/drivers/ssb/main.c:1175: error: implicit
> > > > declaration of function 'pci_set_consistent_dma_mask'
> > > >
> > > > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> > >
> > > Applied to linux-next, thanks Randy.
> >
> > I guess this is probably also needed for 2.6.26.
> 
> Hm, current upstream seems to have pci_set_consistent_dma_mask under 
> CONFIG_SSB_PCIHOST, which in turn depends on PCI = y (or PCI = SSB, what does 
> that mean?).
> 
> But yeah, it wouldn't hurt to push this for 2.6.26 too.

Yeah, I wasn't talking about ssb, but rather other drivers.
Maybe there's no such user of that function, however.

-- 
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/