linux-kernel - Re: [PATCH 19/60] microblaze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4117.6640-711-1819091302-1214810290@seznam.cz>
Date:	Mon, 30 Jun 2008 09:18:10 +0200 (CEST)
From:	Michal Simek <Monstr@...nam.cz>
To:	Segher Boessenkool <segher@...nel.crashing.org>
Cc:	hpa@...or.com, John.Linn@...inx.com, arnd@...db.de,
	drepper@...hat.com, matthew@....cx, john.williams@...alogix.com,
	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk,
	linuxppc-dev@...abs.org,
	Michal Simek <monstr@...str.eu>,
	vapier.adi@...il.com, microblaze-uclinux@...e.uq.edu.au,
	linux-arch@...r.kernel.org, will.newton@...il.com
Subject: Re: [PATCH 19/60] microblaze_v4: checksum support

Hi Segher,

you find bug because there is microblaze asm code in generic folder. 
Big thanks. I'll fix it and I'll look at parameters too.

Michal

> +static inline unsigned int
> +csum_tcpudp_nofold(unsigned long saddr, unsigned long daddr, unsigned 
> short len,
> +		unsigned short proto, unsigned int sum)
> +{
> +	__asm__("add %0, %4, %1\n\t"
> +		"addc %0, %4, %2\n\t"
> +		"addc %0, %4, %3\n\t"
> +		"addc %0, %4, r0\n\t"
> +		: "=d" (sum)
> +		: "d" (saddr), "d" (daddr), "d" (len + proto),
> +		"0"(sum));

"sum" should use an earlyclobber, i.e.  "=&d"(sum)  , since some
inputs are used after %0 is first written to.

Also, you can use "+" instead of "=" to say the argument is both
input and output, and get rid of %4, if you like.


Segher



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/