| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 01 Jul 2008 17:33:36 +0900 From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> To: Christoph Hellwig <hch@...radead.org> Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/7] fat: Fix VFAT_IOCTL_READDIR_xxx and cleanup for userland Christoph Hellwig <hch@...radead.org> writes: > On Tue, Jul 01, 2008 at 11:57:03AM +0900, OGAWA Hirofumi wrote: >> >> "struct dirent" is a kernel type here, but is a **different type** in >> userspace! This means both the structure and the IOCTL number is wrong! >> >> So, this adds new "struct __fat_dirent" to generate correct IOCTL >> number. And kernel stuff moves to under __KERNEL__. > > Given that the current version can't actually work without defininig > it's own dirent and thus ioctl number symbolic name I wonder if these > ioctls are used at all? They must have been completely untested for > a while, and I suspect we'd be better off just removing them. I'm not sure whether all users doesn't use. (If user uses correct dirent like I did to test in past, it generates correct number.) Anyway, why is it better off? I think, if users which copied, this patch shouldn't have any impact, and other users can use fixed version? -- OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists