linux-kernel - Re: Ctrl+C doesn't interrupt process waiting for I/O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4869F502.5030201@davidnewall.com>
Date:	Tue, 01 Jul 2008 18:42:34 +0930
From:	David Newall <davidn@...idnewall.com>
To:	Török Edwin <edwintorok@...il.com>
CC:	Elias Oltmanns <eo@...ensachen.de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Joe Peterson <joe@...rush.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: Ctrl+C doesn't interrupt process waiting for I/O

Török Edwin wrote:
> David Newall wrote:
>   
>> Elias Oltmanns wrote:
>>   
>>     
>>> -			if (!L_NOFLSH(tty)) {
>>> -				n_tty_flush_buffer(tty);
>>> -				tty_driver_flush_buffer(tty);
>>> -			}
>>>  			if (L_ECHO(tty))
>>>  				echo_char(c, tty);
>>> -			if (tty->pgrp)
>>> -				kill_pgrp(tty->pgrp, signal, 1);
>>> +			isig(signal, tty, 0);
>>>     
>>>       
>> My first reaction is that tty->pgrp must be null.  Perhaps the patch
>> could be simplified...
>>
>>  			if (tty->pgrp)
>>  				kill_pgrp(tty->pgrp, signal, 1);
>> +			else
>> +				isig(signal, tty, 0);
>>
>>
>> Thoughts?
>>   
>>     
>
> isig has the same check, if it is NULL, isig won't deliver the signal
> either
>   

That is odd.  We did see the control-key echoed, so, other than not
flushing output, what's funcitonally different?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/