linux-kernel - RE: [PATCH 11/13] viafb: viafbdev.c, viafbdev.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Jul 2008 09:14:01 +0800
From:	<JosephChan@....com.tw>
To:	<jirislaby@...il.com>
Cc:	<linux-fbdev-devel@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>, <akpm@...ux-foundation.org>,
	<geert@...ux-m68k.org>
Subject: RE: [PATCH 11/13] viafb: viafbdev.c, viafbdev.h

Jiri,

Thanks for your comments, I will let our engineers to check those items you mentioned. 

BRs,
Joseph Chan 


-----Original Message-----
From: Jiri Slaby [mailto:jirislaby@...il.com] 
Sent: Tuesday, July 01, 2008 3:56 AM
To: Joseph Chan
Cc: linux-fbdev-devel@...ts.sourceforge.net; linux-kernel@...r.kernel.org; akpm@...ux-foundation.org; geert@...ux-m68k.org
Subject: Re: [PATCH 11/13] viafb: viafbdev.c, viafbdev.h

On 06/30/2008 09:46 AM, JosephChan@....com.tw wrote:
> Initialization, remove and some other important functions of viafb.
> 
> Signed-off-by: Joseph Chan <josephchan@....com.tw>
> 
> diff -Nur a/drivers/video/via/viafbdev.c b/drivers/video/via/viafbdev.c
> --- a/drivers/video/via/viafbdev.c	1970-01-01 08:00:00.000000000 +0800
> +++ b/drivers/video/via/viafbdev.c	2008-06-30 08:53:33.000000000 +0800
> @@ -0,0 +1,2659 @@
[...]
> +static int timer_on;
> +struct timer_list timer_for3D;

Well the timer is neither inited nor used... ?