linux-kernel - RE: [PATCH 7/13] viafb: iface.c, iface.h, ioctl.c, ioctl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Jul 2008 09:20:31 +0800
From:	<JosephChan@....com.tw>
To:	<alan@...rguk.ukuu.org.uk>
Cc:	<linux-fbdev-devel@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>, <akpm@...ux-foundation.org>,
	<geert@...ux-m68k.org>
Subject: RE: [PATCH 7/13] viafb: iface.c, iface.h, ioctl.c, ioctl.h

Alan,

Thanks to remind.
Is it good to add viafb_ , ex: viafb_get_memsize(void)?
It would be great to have your comment. Thanks again.

BRs,
Joseph Chan 

-----Original Message-----
From: Alan Cox [mailto:alan@...rguk.ukuu.org.uk] 
Sent: Monday, June 30, 2008 5:40 PM
To: Joseph Chan
Cc: Joseph Chan; linux-fbdev-devel@...ts.sourceforge.net; linux-kernel@...r.kernel.org; akpm@...ux-foundation.org; geert@...ux-m68k.org
Subject: Re: [PATCH 7/13] viafb: iface.c, iface.h, ioctl.c, ioctl.h


> +/* Get frame buffer size from VGA BIOS */
> +
> +unsigned int get_memsize(void)

Not a good name for a globally visible function!

> +unsigned long get_videobuf_addr(void) {

Ditto