linux-kernel - Re: [PATCH 2/7] fat: Fix VFAT_IOCTL_READDIR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 Jul 2008 22:15:30 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] fat: Fix VFAT_IOCTL_READDIR_xxx and cleanup for userland

Christoph Hellwig <hch@...radead.org> writes:

>>  #include <linux/magic.h>
>> +#include <asm/byteorder.h>
>
> Why do we need this in the user-visible part of the header?

It was just moved from line below of this.

>> +struct __fat_dirent {
>> +	long		d_ino;
>> +	__kernel_off_t	d_off;
>> +	unsigned short	d_reclen;
>> +	char		d_name[256]; /* We must not include limits.h! */
>> +};
>
> Any reason this is not called fat_dirent? 

It was suggested, and I thought it's safe.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/