linux-kernel - Re: [RFC 0/5] percpu: Optimize percpu accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080701145417.GB18522@elte.hu>
Date:	Tue, 1 Jul 2008 16:54:17 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mike Travis <travis@....com>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC 0/5] percpu: Optimize percpu accesses


* Mike Travis <travis@....com> wrote:

> This patchset provides the following:
> 
>   * Cleanup: Fix early references to cpumask_of_cpu(0)
>   * Generic: Percpu infrastructure to rebase the per cpu area to zero
>   * x86_64: Fold pda into per cpu area
>   * x86_64: Rebase per cpu variables to zero

thanks Mike - i've started testing it in -tip. One small merge fallout 
fix is below. (it's for the new generic-ipi topic that was not in 
tip/master yet when you merged percpu-zerobased to it)

	Ingo

---------------->
commit d1d4ed23aab090298b9d4da0fe445b96afcdd309
Author: Ingo Molnar <mingo@...e.hu>
Date:   Tue Jul 1 16:44:45 2008 +0200

    x86: percpu-zerobased fallout fixlet
    
    add_pda(x,1) => x86_inc_percpu(pda.x)
    
    Signed-off-by: Ingo Molnar <mingo@...e.hu>

diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
index 361b7a4..1ddf629 100644
--- a/arch/x86/kernel/smp.c
+++ b/arch/x86/kernel/smp.c
@@ -206,7 +206,7 @@ void smp_call_function_single_interrupt(struct pt_regs *regs)
 #ifdef CONFIG_X86_32
 	__get_cpu_var(irq_stat).irq_call_count++;
 #else
-	add_pda(irq_call_count, 1);
+	x86_inc_percpu(pda.irq_call_count);
 #endif
 	irq_exit();
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/