linux-kernel - Re: [PATCH 1 of 2] fbcon: bgcolor fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Jul 2008 17:51:52 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1 of 2] fbcon: bgcolor fix


On Tuesday 2008-07-01 17:38, Stefano Stabellini wrote:

>The forth bit of the background color is the blink property bit, not the
>intensity bit, as for the foreground color.
>Therefore it shouldn't be included in the background color.

I'm a bit skeptical, though I have not tried this.
ISTR fb has the power to render full 8 bits background
in addition to blinking.

>--- a/drivers/video/console/fbcon.h
>+++ b/drivers/video/console/fbcon.h
>@@ -92,7 +92,7 @@ struct fbcon_ops {
> #define attr_fgcol(fgshift,s)    \
> 	(((s) >> (fgshift)) & 0x0f)
> #define attr_bgcol(bgshift,s)    \
>-	(((s) >> (bgshift)) & 0x0f)
>+	(((s) >> (bgshift)) & 0x07)
> 
> /* Monochrome */
> #define attr_bold(s) \
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/