linux-kernel - Re: [ofa-general] Re: [RFC PATCH] - scripts/CodingStyle_sizeof - standardize sizeof and [PATCH] drivers/infiniband

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <486A83C1.9090803@gmail.com>
Date:	Tue, 01 Jul 2008 21:21:37 +0200
From:	Dotan Barak <dotanba@...il.com>
To:	Roland Dreier <rdreier@...co.com>
CC:	Joe Perches <joe@...ches.com>, LKML <linux-kernel@...r.kernel.org>,
	general@...ts.openfabrics.org
Subject: Re: [ofa-general] Re: [RFC PATCH] - scripts/CodingStyle_sizeof -
 standardize sizeof and [PATCH] drivers/infiniband - standardize sizeof(foo)

Roland Dreier wrote:
> This seems like needless churn to me.  I personally prefer to see
> "sizeof foo" instead of "sizeof(foo)", since sizeof is not a function,
> and in any case I don't see much value in making this type of trivial
> change.
>   
In the IB stack i noticed all of the variations of sizeof:
sizeof foo
   or
sizeof(foo)
   (and i think that i even saw)
sizeof (foo)


IMHO, Changing all of the instances of "sizeof" from all of the 
variations to a unified one can make
the code look a little bit better ...

Dotan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/