linux-kernel - Re: next-0630: sparc64: build failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080701200344.GA4896@elte.hu>
Date:	Tue, 1 Jul 2008 22:03:44 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Abhishek Sagar <sagar.abhishek@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Alexander Beregalov <a.beregalov@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-next@...r.kernel.org, sparclinux@...r.kernel.org,
	rostedt@...dmis.org
Subject: Re: next-0630: sparc64: build failed


* Abhishek Sagar <sagar.abhishek@...il.com> wrote:

> Hi Ingo/David,
> 
> CONFIG_MCOUNT currently controls the compilation with -pg flag and the 
> export of _mcount. But with ftrace, the former is redundant and the 
> latter should be made unconditional since _mcount is always defined. 
> In which case, does the inlined patch (untested) make sense? It should 
> solve the build failure as well.

hm, mcount is the facility - so it makes sense to have that defined. 
Here you basically hide CONFIG_MCOUNT:

> -ifeq ($(CONFIG_MCOUNT),y)
> -  KBUILD_CFLAGS += -pg
> +ifneq ($(CONFIG_FTRACE),y)
> +ifeq ($(CONFIG_STACK_DEBUG),y)
> +KBUILD_CFLAGS += -pg
> +endif
>  endif

via two conditions. I'm not sure that's a win and i found CONFIG_MCOUNT 
a logical switch - but it's David's call.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/